Skip to content

twopass.tcl: add support for personalities (kernel module parameters)#91

Closed
ikcalB wants to merge 1 commit intoLinuxCNC:2.6from
ikcalB:2.6-tp_personalities
Closed

twopass.tcl: add support for personalities (kernel module parameters)#91
ikcalB wants to merge 1 commit intoLinuxCNC:2.6from
ikcalB:2.6-tp_personalities

Conversation

@ikcalB
Copy link
Copy Markdown
Contributor

@ikcalB ikcalB commented Jun 28, 2016

Signed-off-by: Florian Kerle flo.kerle@gmx.at

Signed-off-by: Florian Kerle <flo.kerle@gmx.at>
@jepler
Copy link
Copy Markdown
Contributor

jepler commented Jul 15, 2016

@ikcalB I have pushed a branch to git.linuxcnc.org that merges this commit to master and then adds a small test of the new functionality. this is branch LinuxCNC:jepler/master/ickalb-tp-personalities which should appear here on github shortly.

@SebKuzminsky I assume you are reluctant to take this for a branch like 2.6 that is in stable release mode, so for now my goal is to merge this only to master branch, not to older branches. Let me know if you feel otherwise. Since I would want to test this functionality, it would also require backporting these commits, or else converting the test to something that runs full LinuxCNC to get the twopass function.

37e6fc4 testsuite: basic test of twopass
29d5c45 halrun: If an inifile is specified, run it as twopass
ed79921 halcmd: add "twopass" version as executable script

@SebKuzminsky
Copy link
Copy Markdown
Collaborator

@ikcalB Is the lack of this functionality in 2.6 a problem for you or anyone you know of?

@ikcalB
Copy link
Copy Markdown
Contributor Author

ikcalB commented Jul 19, 2016

@jepler thank you!

@SebKuzminsky I'm not aware of anyone else reporting this problem - though I am sure, some ppl using twopass and personalities have wondered why using both together breaks their setup, hence have taken a workaround. Afaik if somone is required to use twopass, one cannot use personalities if he'd like to.

@SebKuzminsky
Copy link
Copy Markdown
Collaborator

Let's put it in master, we can backport it if someone needs it in a stable branch.

@ikcalB
Copy link
Copy Markdown
Contributor Author

ikcalB commented Jul 19, 2016

Agreed. Closing this for now

@ikcalB ikcalB closed this Jul 19, 2016
@jepler
Copy link
Copy Markdown
Contributor

jepler commented Jul 19, 2016

No need to create a fresh PR, I merged this one to our master branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants